Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(claim): implement CompleteMission #836

Merged
merged 24 commits into from
Jun 11, 2022
Merged

feat(claim): implement CompleteMission #836

merged 24 commits into from
Jun 11, 2022

Conversation

lumtis
Copy link
Contributor

@lumtis lumtis commented Jun 7, 2022 •
edited
Loading

  • Implement CompleteMission that defines logic for claimable airdrop distribution
  • Add method tests
  • Add airdrop supply initialization (module account mint the airdrop supply at genesis initialization)

@lumtis lumtis marked this pull request as ready for review June 7, 2022 18:47
@lumtis lumtis linked an issue Jun 7, 2022 that may be closed by this pull request
Implement Distribute method #784
Closed
@lumtis lumtis marked this pull request as draft June 7, 2022 19:06
@codecov
Copy link

codecov bot commented Jun 8, 2022 •
edited
Loading

Codecov Report

Merging #836 (3d7c859) into develop (44b136f) will increase coverage by 0.07%.
The diff coverage is 85.89%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #836      +/-   ##
===========================================
+ Coverage    10.35%   10.42%   +0.07%     
===========================================
  Files          322      322              
  Lines        75344    75407      +63     
===========================================
+ Hits          7802     7862      +60     
- Misses       67355    67356       +1     
- Partials       187      189       +2
Impacted Files Coverage Δ
x/claim/genesis.go 76.00% <0.00%> (-8.62%) ⬇️
x/claim/keeper/airdrop_supply.go 82.35% <71.42%> (+5.42%) ⬆️
x/claim/keeper/mission.go 95.94% <93.47%> (+2.00%) ⬆️
x/claim/keeper/claim_record.go 100.00% <100.00%> (ø)
x/claim/types/claim_record.go 100.00% <100.00%> (ø)
x/campaign/simulation/store.go 83.10% <0.00%> (+2.02%) ⬆️

@lumtis lumtis marked this pull request as ready for review June 8, 2022 06:46
@lumtis lumtis mentioned this pull request Jun 8, 2022
Closed
aljo242
aljo242 suggested changes Jun 8, 2022
View reviewed changes
x/claim/keeper/airdrop_supply.go Show resolved Hide resolved
x/claim/keeper/claim_record.go Outdated Show resolved Hide resolved
lumtis
lumtis commented Jun 8, 2022
View reviewed changes
x/claim/keeper/claim_record.go Outdated Show resolved Hide resolved
@lumtis
Apply suggestions from code review
288f035 
Co-authored-by: Alex Johnson <alex.johnson@tendermint.com>
@lumtis lumtis requested a review from aljo242 June 8, 2022 17:46
Pantani
Pantani reviewed Jun 8, 2022
View reviewed changes
x/claim/genesis_test.go Outdated Show resolved Hide resolved
x/claim/keeper/grpc_query_airdrop_supply_test.go Outdated Show resolved Hide resolved
x/claim/keeper/grpc_query_airdrop_supply_test.go Outdated Show resolved Hide resolved
x/claim/keeper/grpc_query_airdrop_supply_test.go Show resolved Hide resolved
x/claim/keeper/grpc_query_claim_record_test.go Outdated Show resolved Hide resolved
x/claim/keeper/mission.go Outdated Show resolved Hide resolved
lumtis and others added 2 commits June 9, 2022 13:19
@lumtis @Pantani
Update x/claim/genesis_test.go
1e0d72b 
Co-authored-by: Danilo Pantani <danpantani@gmail.com>
@lumtis
comments
d828285
@lumtis lumtis requested a review from Pantani June 9, 2022 15:46
aljo242
aljo242 previously approved these changes Jun 9, 2022
View reviewed changes
Pantani
Pantani previously approved these changes Jun 10, 2022
View reviewed changes
@lumtis lumtis dismissed stale reviews from Pantani and aljo242 via 3d7c859 June 11, 2022 07:25
@lumtis lumtis merged commit f15ab08 into develop Jun 11, 2022
@lumtis lumtis deleted the feat/claim-distribute branch June 11, 2022 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aljo242 aljo242 aljo242 left review comments

@Pantani Pantani Pantani left review comments

@fadeev fadeev Awaiting requested review from fadeev

@ilgooz ilgooz Awaiting requested review from ilgooz

@ivanovpetr ivanovpetr Awaiting requested review from ivanovpetr

@giunatale giunatale Awaiting requested review from giunatale

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Distribute method
3 participants
@lumtis @Pantani @aljo242