Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(campaign): remove msg add shares #837

Merged
merged 6 commits into from
Jun 8, 2022

Conversation

aljo242
Copy link
Contributor

@aljo242 aljo242 commented Jun 7, 2022

Closes #819

@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #837 (601298c) into develop (832b702) will decrease coverage by 0.02%.
The diff coverage is 55.40%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #837      +/-   ##
===========================================
- Coverage    10.54%   10.52%   -0.03%     
===========================================
  Files          332      330       -2     
  Lines        77755    77249     -506     
===========================================
- Hits          8199     8129      -70     
+ Misses       69348    68915     -433     
+ Partials       208      205       -3     
Impacted Files Coverage Δ
pkg/types/consensus_state.go 100.00% <ø> (ø)
pkg/types/validator_set.go 92.30% <ø> (ø)
x/campaign/simulation/simulation.go 0.00% <ø> (ø)
x/campaign/types/tx.pb.go 0.57% <0.00%> (+<0.01%) ⬆️
x/monitoringc/keeper/monitoring_packet.go 100.00% <ø> (ø)
x/monitoringc/keeper/msg_create_client.go 95.38% <ø> (ø)
x/monitoringc/module_ibc.go 0.00% <0.00%> (ø)
x/monitoringc/types/genesis.go 100.00% <ø> (ø)
x/monitoringp/keeper/begin_block.go 95.38% <ø> (ø)
x/monitoringp/keeper/consumer_client.go 71.42% <ø> (ø)
... and 7 more

Copy link
Contributor

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giunatale giunatale merged commit 2c71cca into develop Jun 8, 2022
@giunatale giunatale deleted the refactor/remove-msg-add-shares branch June 8, 2022 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove MsgAddShares message
3 participants