-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(claim
): add hooks for delegation and vote mission claim
#871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumtis
requested review from
fadeev,
ilgooz,
Pantani,
ivanovpetr,
aljo242 and
giunatale
as code owners
June 14, 2022 15:27
Codecov Report
@@ Coverage Diff @@
## develop #871 +/- ##
===========================================
- Coverage 10.42% 10.39% -0.03%
===========================================
Files 322 325 +3
Lines 75407 75688 +281
===========================================
+ Hits 7862 7869 +7
- Misses 67356 67630 +274
Partials 189 189
|
Pantani
previously approved these changes
Jun 15, 2022
the simulation test is broken |
Yep there was a bug! Not sure why it was only triggered in simulation and not on |
aljo242
approved these changes
Jun 15, 2022
Pantani
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement hooks for
staking
andgov
modules that allow to complete claim mission on the events:staking
gov
Set hooks in
app.go
as a sample implementation.Security mechanism remains to be designed: locking a specific mission ID for a specific module
Add event on mission completion
To test:
Serve:
Claim for delegation mission:
Claim for voting proposal:
Check balance for
drop
token:Check claim records: