Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(claim): add checks in genesis validate for already completed missions #877

Merged
merged 11 commits into from
Jun 21, 2022

Conversation

lumtis
Copy link
Contributor

@lumtis lumtis commented Jun 20, 2022

Already completed missions are now taken into account for checking the airdrop supply value

Add some other improvements

@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #877 (8a5ad75) into develop (b6a5d1d) will increase coverage by 0.02%.
The diff coverage is 80.55%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #877      +/-   ##
===========================================
+ Coverage    10.43%   10.45%   +0.02%     
===========================================
  Files          326      326              
  Lines        76261    76273      +12     
===========================================
+ Hits          7957     7975      +18     
+ Misses       68113    68109       -4     
+ Partials       191      189       -2     
Impacted Files Coverage Δ
x/claim/types/genesis.go 78.57% <78.78%> (+11.18%) ⬆️
x/claim/keeper/mission.go 96.20% <100.00%> (ø)
x/claim/types/claim_record.go 100.00% <100.00%> (ø)
x/campaign/simulation/store.go 83.10% <0.00%> (+2.02%) ⬆️

Pantani
Pantani previously approved these changes Jun 20, 2022
Copy link
Collaborator

@Pantani Pantani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

can you run make format before the merge?

x/claim/types/claim_record_test.go Outdated Show resolved Hide resolved
@lumtis lumtis requested a review from Pantani June 21, 2022 06:24
@lumtis
Copy link
Contributor Author

lumtis commented Jun 21, 2022

Thanks for the approval @Pantani

I'm merging it now as #835 depends on it in some way

@lumtis lumtis merged commit 521ce9d into develop Jun 21, 2022
@lumtis lumtis deleted the refactor/claim-genesis-validate branch June 21, 2022 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Claim's genesis validate: take completed mission in consideration for airdrop supply check
2 participants