Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing a peer from tendermint #1557

Closed
jerrinjames1107 opened this issue May 11, 2018 · 1 comment
Closed

Removing a peer from tendermint #1557

jerrinjames1107 opened this issue May 11, 2018 · 1 comment

Comments

@jerrinjames1107
Copy link

jerrinjames1107 commented May 11, 2018 •
edited
Loading

I had created a multi-node setup using tendermint consensus.Is there a possible way to remove or isolate the added peer from the multinode setup.
@ebuchman
Copy link
Contributor

Not really within Tendermint. You can use iptables or other networking /firewall software to do this. Or you can take down a node.

You can also filter in the ABCI application if you want, but that's more involved: https://github.com/tendermint/tendermint/blob/develop/docs/specification/new-spec/abci.md#peer-filtering.

We don't expose an rpc to disconnect from current nodes, because the Peer-Exchange Reactor is constantly trying to connect to nodes - so it wouldn't make sense. Could be an administrative feature but not a current priority.

Will close this for now, thanks!

@jacohend jacohend mentioned this issue Oct 3, 2019
Closed
4 tasks
firelizzard18 pushed a commit to AccumulateNetwork/tendermint that referenced this issue Feb 1, 2024
@mzabaluev @andynog @melekes
Make LoadBlock also return block metadata (tendermint#1557)
83172f7 
* store: return metadata with LoadBlock

Change the signature of the LoadBlock and LoadBlockByHash
methods to also return block metadata.
Reason: the main implementation fetches block metadata in process of
retrieving the block from parts.
Other implementations should likely do the same.

* state: re-generate the BlockStore mock

* Update tests to LoadBlock changes

In mocks, have LoadBlock return also a `BlockMeta` value.

* Changelog entry for tendermint#1557

* inspect: fix up test expectations for LoadBlock

* consensus: fix off-by-one mistake in mock

Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>

---------

Co-authored-by: Andy Nogueira <me@andynogueira.dev>
Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ebuchman @jerrinjames1107