-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change ed25519 and bcrypt to be forked off golang/x/crypto #1959
Comments
I can see two ways of doing this. One is we fork the entire The other is we keep our current fork of ed25519 (agl's library, x/crypto is basically the same + 2 updates which I've already made PR's for). We also then fork bcrypt and maintain that as a repo. I think having the seperate ed25519 and bcrypt forks is fine. The issue we ran into with the tendermint repos is that we were developing actively on all of them at once. With ed25519/bcrypt, they should be extremely stable. (Any updates they have should not be breaking) |
Why would we keep separate forks? |
We could have a single |
Ok I made one: https://github.com/tendermint/crypto It has the update for bcrypt and I updated cosmos/cosmos-sdk#2090 to use it. Also opened a fork of bip39 rather than copying it in. So cosmos/cosmos-sdk#2090 has both pkgs removed :) |
Closing for #2558 |
* Disable undesired linting code * Added unclog entry
Ref: tendermint/go-crypto#60
/cc @ebuchman
The text was updated successfully, but these errors were encountered: