lite2: indicate success/failure of Update #4536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`error` itself is not enough since it only signals if there were any errors. Either (types.SignedHeader) or (success bool) is needed to indicate the status of the operation. Returning a header is optimal since most of the clients will want to get a newly verified header anyway.
cmwaters
approved these changes
Mar 6, 2020
There was a problem hiding this comment.
👍 -> the only qualm I have is that if you wanted to grab the latest header on the chain, you would have to first run Update() and then check if the header was nil, and if so then run TrustedHeader(0). I guess this is a matter of: is signalling that the state of the light client has updated more important than retrieving the latest header, regardless of whether it has been verified before.
Codecov Report
@@ Coverage Diff @@
## master #4536 +/- ##
==========================================
+ Coverage 65.26% 65.33% +0.07%
==========================================
Files 229 229
Lines 20272 20273 +1
==========================================
+ Hits 13230 13245 +15
+ Misses 5988 5979 -9
+ Partials 1054 1049 -5
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
erroritself is not enough since it only signals if there were anyerrors. Either (types.SignedHeader) or (success bool) is needed to
indicate the status of the operation. Returning a header is optimal
since most of the clients will want to get a newly verified header
anyway.
For contributor use:
docs/) and code commentsFiles changedin the Github PR explorer