Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: support EXISTS operator in /tx_search query #4979

Merged
merged 10 commits into from
Jun 9, 2020
Merged

Conversation

melekes
Copy link
Contributor

@melekes melekes commented Jun 8, 2020

Closes #4763

@melekes melekes requested a review from tessr as a code owner June 8, 2020 07:05
@auto-comment
Copy link

auto-comment bot commented Jun 8, 2020

👋 Thanks for creating a PR!

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Wrote tests
  • Updated CHANGELOG_PENDING.md
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments
  • Re-reviewed Files changed in the Github PR explorer
  • Applied Appropriate Labels

Thank you for your contribution to Tendermint! 🚀

@melekes melekes self-assigned this Jun 8, 2020
@melekes melekes added R:minor Release: Minor S:automerge Automatically merge PR when requirements pass labels Jun 8, 2020
@codecov
Copy link

codecov bot commented Jun 8, 2020

Codecov Report

Merging #4979 into master will decrease coverage by 0.06%.
The diff coverage is 36.84%.

@@            Coverage Diff             @@
##           master    #4979      +/-   ##
==========================================
- Coverage   62.77%   62.70%   -0.07%     
==========================================
  Files         175      175              
  Lines       15926    15938      +12     
==========================================
- Hits         9997     9994       -3     
- Misses       5080     5091      +11     
- Partials      849      853       +4     
Impacted Files Coverage Δ
state/txindex/kv/kv.go 66.02% <36.84%> (-1.90%) ⬇️
blockchain/v2/reactor.go 35.92% <0.00%> (-2.97%) ⬇️
blockchain/v0/reactor.go 62.21% <0.00%> (-0.93%) ⬇️
blockchain/v0/pool.go 78.66% <0.00%> (-0.32%) ⬇️
p2p/pex/pex_reactor.go 80.95% <0.00%> (+0.52%) ⬆️
behaviour/reporter.go 57.69% <0.00%> (+9.20%) ⬆️

@tac0turtle
Copy link
Contributor

do we have somewhere in the docs explaining the indexer? if so we should add this there

@melekes melekes merged commit 6ec58f1 into master Jun 9, 2020
@melekes melekes deleted the anton/4763-exists branch June 9, 2020 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R:minor Release: Minor S:automerge Automatically merge PR when requirements pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add EXISTS condition for tx_search
3 participants