Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: removal of multisig #4988

Merged
merged 4 commits into from
Jun 9, 2020
Merged

crypto: removal of multisig #4988

merged 4 commits into from
Jun 9, 2020

Conversation

tac0turtle
Copy link
Contributor

@tac0turtle tac0turtle commented Jun 9, 2020 •
edited
Loading

Description

deprecation & removal of multisig. This key was only used in the sdk and now it has been added there

Closes: #4715
Closes: #2163

@auto-comment
Copy link

auto-comment bot commented Jun 9, 2020

👋 Thanks for creating a PR!

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Wrote tests
  • Updated CHANGELOG_PENDING.md
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments
  • Re-reviewed Files changed in the Github PR explorer
  • Applied Appropriate Labels

Thank you for your contribution to Tendermint! 🚀

@tac0turtle tac0turtle self-assigned this Jun 9, 2020
@tac0turtle tac0turtle added C:crypto Component: Crypto T:code-hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. labels Jun 9, 2020
@tac0turtle tac0turtle marked this pull request as ready for review June 9, 2020 07:44
@codecov
Copy link

codecov bot commented Jun 9, 2020 •
edited
Loading

Codecov Report

Merging #4988 into master will increase coverage by 0.56%.
The diff coverage is 36.84%.

@@            Coverage Diff             @@
##           master    #4988      +/-   ##
==========================================
+ Coverage   62.71%   63.28%   +0.56%     
==========================================
  Files         174      185      +11     
  Lines       15959    19822    +3863     
==========================================
+ Hits        10009    12544    +2535     
- Misses       5091     6252    +1161     
- Partials      859     1026     +167
Impacted Files Coverage Δ
crypto/encoding/amino/amino.go 100.00% <ø> (ø)
state/txindex/kv/kv.go 66.02% <36.84%> (-1.90%) ⬇️
libs/events/events.go 93.20% <0.00%> (-4.86%) ⬇️
blockchain/v2/routine.go 77.61% <0.00%> (-2.99%) ⬇️
blockchain/v2/reactor.go 35.92% <0.00%> (-1.49%) ⬇️
blockchain/v0/pool.go 78.66% <0.00%> (-0.32%) ⬇️
state/execution.go
state/tx_filter.go
state/metrics.go
crypto/merkle/codec.go
... and 62 more

@tac0turtle tac0turtle added the S:automerge Automatically merge PR when requirements pass label Jun 9, 2020
@mergify mergify bot merged commit 6961c7e into master Jun 9, 2020
@mergify mergify bot deleted the marko/4715remove_multisig branch June 9, 2020 08:13
melekes pushed a commit that referenced this pull request Jun 10, 2020
@tac0turtle @melekes
crypto: removal of multisig (#4988)
335ebe2 
## Description

deprecation & removal of multisig. This key was only used in the sdk and now it has been added there

Closes: #4715 
Closes: #2163
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melekes melekes melekes approved these changes

@tessr tessr Awaiting requested review from tessr

Assignees

@tac0turtle tac0turtle

Labels
C:crypto Component: Crypto S:automerge Automatically merge PR when requirements pass T:code-hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

crypto: multisig deprecation Implement multisig ADR
2 participants
@tac0turtle @melekes