evidence: introduction of LightClientAttackEvidence and refactor of evidence lifecycle #5361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmwaters
requested review from
ebuchman,
erikgrinaker,
melekes and
tessr
as code owners
Codecov Report
@@ Coverage Diff @@
## master #5361 +/- ##
==========================================
+ Coverage 60.90% 61.46% +0.56%
==========================================
Files 258 259 +1
Lines 23080 23346 +266
==========================================
+ Hits 14056 14349 +293
+ Misses 7588 7536 -52
- Partials 1436 1461 +25
|
melekes
reviewed
Sep 16, 2020
| bz := make([]byte, tmhash.Size+n) | ||
| copy(bz[:tmhash.Size-1], l.ConflictingBlock.Hash().Bytes()) | ||
| copy(bz[tmhash.Size:], buf) | ||
| return tmhash.Sum(bz) |
There was a problem hiding this comment.
do we want to memoize the hash to avoid recomputing it several times?
same question for duplicate vote evidence
There was a problem hiding this comment.
I'll check how many times we compute the hash. I actually don't think we do it that often
There was a problem hiding this comment.
So we compute the hash at most three times when evidence passes through the evidence pool. Do you thing that warrants saving the hash?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For more description see ADR-059