Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: change default sorting to desc for /tx_search results #6168

Merged
merged 2 commits into from
Feb 23, 2021

Conversation

melekes
Copy link
Contributor

@melekes melekes commented Feb 23, 2021

Closes #6155

@melekes melekes self-assigned this Feb 23, 2021
@codecov
Copy link

codecov bot commented Feb 23, 2021

Codecov Report

Merging #6168 (61d322c) into master (42f6c40) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #6168      +/-   ##
==========================================
- Coverage   60.69%   60.63%   -0.07%     
==========================================
  Files         276      276              
  Lines       25706    25706              
==========================================
- Hits        15603    15586      -17     
- Misses       8482     8495      +13     
- Partials     1621     1625       +4     
Impacted Files Coverage Δ
rpc/core/tx.go 0.00% <0.00%> (ø)
privval/signer_listener_endpoint.go 80.00% <0.00%> (-9.42%) ⬇️
mempool/reactor.go 65.71% <0.00%> (-5.00%) ⬇️
privval/socket_listeners.go 78.72% <0.00%> (-4.26%) ⬇️
privval/signer_endpoint.go 75.75% <0.00%> (-3.04%) ⬇️
privval/secret_connection.go 73.71% <0.00%> (-2.58%) ⬇️
consensus/reactor.go 67.24% <0.00%> (-2.36%) ⬇️
consensus/peer_state.go 78.94% <0.00%> (-0.88%) ⬇️
mempool/clist_mempool.go 80.21% <0.00%> (-0.72%) ⬇️
proxy/multi_app_conn.go 48.05% <0.00%> (ø)
... and 10 more

@melekes melekes marked this pull request as ready for review February 23, 2021 10:48
@melekes melekes added the S:automerge Automatically merge PR when requirements pass label Feb 23, 2021
Copy link
Contributor

@cmwaters cmwaters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mergify mergify bot merged commit c1ca749 into master Feb 23, 2021
@mergify mergify bot deleted the anton/6155-tx-search branch February 23, 2021 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S:automerge Automatically merge PR when requirements pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TxSearch to return results in descending order by default
2 participants