Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Range to NewIterator #134

Merged
merged 7 commits into from
Nov 9, 2020
Merged

add Range to NewIterator #134

merged 7 commits into from
Nov 9, 2020

Conversation

klim0v
Copy link
Contributor

@klim0v klim0v commented Nov 9, 2020

I see a slowdown when using iterations in the cosmos/iavl#324 (comment) library in the case where the given key cannot be found. I guess this is because the newGoLevelDBIterator function uses Seek(), which has to go through the whole tree to make sure the key is missing.

@klim0v
Copy link
Contributor Author

klim0v commented Nov 9, 2020

Error: requested golangci-lint version 'v1.26' isn't supported: we support only v1.28.3 and later versions

Can you fix the lint/golangci config?

@tac0turtle
Copy link
Contributor

Can you fix the lint/golangci config?

Could you make this PR against master, this error won't arise there, after that it can be back ported?

@melekes melekes changed the base branch from 0.5.x to master November 9, 2020 14:47
@melekes
Copy link
Contributor

melekes commented Nov 9, 2020

wow, what a great find!

erikgrinaker
erikgrinaker reviewed Nov 9, 2020
View reviewed changes
goleveldb.go Outdated Show resolved Hide resolved
@erikgrinaker
Copy link
Contributor

erikgrinaker commented Nov 9, 2020 •
edited
Loading

Can you add an entry for this in CHANGELOG.md as well please?

@codecov
Copy link

codecov bot commented Nov 9, 2020 •
edited
Loading

Codecov Report

Merging #134 (84135c5) into master (772df13) will decrease coverage by 0.69%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
- Coverage   69.47%   68.78%   -0.70%     
==========================================
  Files          27       27              
  Lines        1448     1448              
==========================================
- Hits         1006      996      -10     
- Misses        370      377       +7     
- Partials       72       75       +3
Impacted Files Coverage Δ
goleveldb.go 58.33% <100.00%> (ø)
goleveldb_iterator.go 75.43% <0.00%> (-17.55%) ⬇️
Impacted Files Coverage Δ
goleveldb.go 58.33% <100.00%> (ø)
goleveldb_iterator.go 75.43% <0.00%> (-17.55%) ⬇️

erikgrinaker
erikgrinaker reviewed Nov 9, 2020
View reviewed changes
goleveldb.go Outdated Show resolved Hide resolved
@klim0v
Copy link
Contributor Author

klim0v commented Nov 9, 2020 •
edited
Loading

Can you add an entry for this in CHANGELOG.md as well please?

It's okay?

erikgrinaker
erikgrinaker reviewed Nov 9, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@erikgrinaker erikgrinaker merged commit feb7d28 into tendermint:master Nov 9, 2020
@erikgrinaker
Copy link
Contributor

erikgrinaker commented Nov 9, 2020 •
edited
Loading

Thanks! I'll run some tests with IAVL, Tendermint and the SDK using this change, and if it looks good I'll backport to 0.5.x and cut new releases - won't be able to do this until tomorrow though, since I need to finish up some other work tonight.

@klim0v
Copy link
Contributor Author

klim0v commented Nov 9, 2020

Thank you, I was happy to contribute to the common cause!

erikgrinaker pushed a commit that referenced this pull request Nov 10, 2020
@erikgrinaker
goleveldb: bound iterator range for improved performance (#134)
a8738cd
@erikgrinaker erikgrinaker mentioned this pull request Nov 10, 2020
Merged
erikgrinaker pushed a commit that referenced this pull request Nov 10, 2020
@erikgrinaker
goleveldb: bound iterator range for improved performance (#134)
5a56661
erikgrinaker pushed a commit that referenced this pull request Nov 10, 2020
@erikgrinaker
goleveldb: bound iterator range for improved performance (#134)
52e57bf
faddat pushed a commit to faddat/tm-db that referenced this pull request Feb 21, 2024
@dependabot
build(deps): bump golangci/golangci-lint-action from 3.7.1 to 4.0.0 (t…
e509b9e 
…endermint#134)

Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 3.7.1 to 4.0.0.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases)
- [Commits](golangci/golangci-lint-action@v3.7.1...v4.0.0)

---
updated-dependencies:
- dependency-name: golangci/golangci-lint-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikgrinaker erikgrinaker erikgrinaker approved these changes

@melekes melekes Awaiting requested review from melekes

@tessr tessr Awaiting requested review from tessr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@klim0v @tac0turtle @melekes @erikgrinaker