Standardized Development Environment #274
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faddat
requested review from
alexanderbez,
cmwaters,
creachadair,
tac0turtle,
tychoish and
williambanfield
as code owners
tac0turtle
reviewed
Jul 29, 2022
| @@ -0,0 +1 @@ | |||
| image: ghcr.io/notional-labs/cosmos | |||
There was a problem hiding this comment.
what's wrong with the Tendermint-dev docker image?
There was a problem hiding this comment.
I should close this PR, because if we change to the notional one it should be done as a part of #278
in 278 we would become incompatible with the tendermint-dev docker image.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Yesterday I made some changes to the standard dev env that we're using and to my surprise, they "just worked". That includes adding docker to the image so that we could do protocol buffer builds. It also has all the rocksdb tooling installed in the filesystem for those with container allergies.
Caveat: the rocksdb installed here is of the v7 variety. We would want to update our rocks library to grocksdb.
That image is built here daily using cron via github actions and each build is observable.
https://github.com/notional-labs/containers/blob/master/cosmos/Dockerfile