Add integration tests for yubihsm subcommands #121
Conversation
- import subcommand takes optional kms config path
liamsi
force-pushed
the
test_commands
branch
2 times, most recently
from
697391a to
3ddba11
Compare
liamsi
changed the title
liamsi
force-pushed
the
test_commands
branch
from
3ddba11 to
5817ab3
Compare
|
@liamsi FWIW, I'm ok with using 1.30+ |
|
Cool, should we update the docker file then? Should I create a new one? |
|
@liamsi yeah, I'd suggest updating the Dockerfile (maybe in a separate PR, as this seems to be OK for now) |
| String::from_utf8(out.stderr) | ||
| .unwrap() | ||
| .trim() | ||
| .starts_with("error: no keys in this YubiHSM") |
There was a problem hiding this comment.
We can probably add more realistic integration tests too.
sth along the lines of:
list -> generate -> list -> import -> list
There was a problem hiding this comment.
The main problem with that sort of thing right now is the MockHSM does not persist its state between invocations of tmkms.
I could look into some way to do that though (if nothing else just making its internal state Serializeable and dumping it to a JSON file or something)
There was a problem hiding this comment.
I think that would be neat. But I also think it's probably not a high priority I guess.
ref #114