This repository has been archived by the owner on Jun 3, 2020. It is now read-only.
Support Id generation from ed25519 pubkeys #291
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell these
Id::from
methods aren't even being used yet - is that right? In any case, here's the ed25519 one. Also the secp256k1 one is missing a ripemd160 if it's supposed to match Tendermint Core.Why are these called
Id
and notAddress
?