Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build failures on ubuntu 16.04 #340

Merged

Conversation

Infinoid
Copy link
Contributor

@Infinoid Infinoid commented Dec 7, 2020

Fixes #274

This fixes two classes of build failure that happen on Ubuntu 16.04.

  1. gcc 5.4.0 fails to call the createAccessIterators member function properly
  2. gcc 5.4.0 can't decide between two constructors: Tensor(name, shape, Format) and Tensor(name, shape, ModeFormat)

Taco builds successfully on Ubuntu 16.04 with this patch.

I tested with -DOPENMP=ON and -DPYTHON=ON. Issue #316 happened; otherwise all tests passed. I did not test CUDA.

@stephenchouca stephenchouca merged commit 7232529 into tensor-compiler:master Dec 7, 2020
@Infinoid Infinoid deleted the ubuntu-16-04-build-failures branch December 7, 2020 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants