fix: Remove dump checkout and remove pre-commit (#982)

* fix: Remove dump checkout Signed-off-by: Ce Gao <cegao@tensorchord.ai> * fix: Remove pre-commit Signed-off-by: Ce Gao <cegao@tensorchord.ai> * fix: Update Signed-off-by: Ce Gao <cegao@tensorchord.ai> * fix: Update Signed-off-by: Ce Gao <cegao@tensorchord.ai> * fix: Update Signed-off-by: Ce Gao <cegao@tensorchord.ai> * fix: Update Signed-off-by: Ce Gao <cegao@tensorchord.ai> * fix: Update Signed-off-by: Ce Gao <cegao@tensorchord.ai> * fix: Update Signed-off-by: Ce Gao <cegao@tensorchord.ai> Signed-off-by: Ce Gao <cegao@tensorchord.ai>
tensorchord · Oct 8, 2022 · 0be9969 · 0be9969
1 parent f4ebb02
commit 0be9969
Show file tree

Hide file tree

Showing 14 changed files with 21 additions and 18 deletions.
diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml
@@ -38,26 +38,16 @@ jobs:
             ${{ runner.OS }}-build-${{ env.cache-name }}-
             ${{ runner.OS }}-build-
             ${{ runner.OS }}-
-      - run: go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.50.0
-      - run: echo "${HOME}/.local/bin" >> $GITHUB_PATH
       - name: Add license
         run: |
           make addlicense && git add pkg cmd &&
           git diff --cached --exit-code || (echo 'Please run "make addlicense" to verify govet' && exit 1);
-      - uses: actions/checkout@v3
-      - uses: actions/setup-python@v4
-        with:
-          python-version: '3.11.0-beta.3'
-        env:
-          AGENT_TOOLSDIRECTORY: /opt/hostedtoolcache
-          RUNNER_TOOL_CACHE: /opt/hostedtoolcache
-      - id: file_changes
-        uses: trilom/file-changes-action@v1.2.4
-        with:
-          output: ' '
-      - uses: pre-commit/action@v3.0.0
+      - name: golangci-lint
+        uses: golangci/golangci-lint-action@v3
         with:
-          extra_args: --files ${{ steps.file_changes.outputs.files}}
+          version: latest
+          # Ref https://github.com/golangci/golangci-lint-action/issues/244
+          skip-pkg-cache: true
   test:
     name: test
     strategy:

diff --git a/.golangci.yml b/.golangci.yml
@@ -11,7 +11,6 @@ linters:
     - govet
     - ineffassign
     - misspell
-    - noloopclosure
     - rowserrcheck
     - sqlclosecheck
     - staticcheck

diff --git a/pkg/builder/builder.go b/pkg/builder/builder.go
@@ -201,6 +201,7 @@ func (b generalBuilder) addBuilderTag(labels *map[string]string) {
 	(*labels)[types.ImageLabelCacheHash] = b.manifestCodeHash
 }
 
+// nolint:unparam
 func (b generalBuilder) imageConfig(ctx context.Context) (string, error) {
 	labels, err := ir.Labels()
 	if err != nil {
@@ -379,7 +380,7 @@ func (b generalBuilder) checkIfNeedBuild(ctx context.Context) bool {
 	return true
 }
 
-// Always return updated when met error
+// nolint:unparam
 func (b generalBuilder) checkDepsFileUpdate(ctx context.Context, tag string, manifest string, deps []string) (bool, error) {
 	dockerClient, err := docker.NewClient(ctx)
 	if err != nil {

diff --git a/pkg/builder/util_test.go b/pkg/builder/util_test.go
@@ -11,6 +11,7 @@
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
+
 package builder
 
 import (

diff --git a/pkg/editor/vscode/vscode_test.go b/pkg/editor/vscode/vscode_test.go
@@ -11,6 +11,7 @@
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
+
 package vscode
 
 import (

diff --git a/pkg/lang/ir/conda.go b/pkg/lang/ir/conda.go
@@ -154,6 +154,7 @@ func (g Graph) compileCondaEnvironment(root llb.State) (llb.State, error) {
 	return run.Root(), nil
 }
 
+// nolint:unparam
 func (g Graph) installConda(root llb.State) (llb.State, error) {
 	if g.CondaConfig.UseMicroMamba {
 		run := root.AddEnv("MAMBA_BIN_DIR", condaBinDir).

diff --git a/pkg/lang/ir/custom.go b/pkg/lang/ir/custom.go
@@ -21,6 +21,7 @@ import (
 	"github.com/moby/buildkit/client/llb"
 )
 
+// nolint:unparam
 func (g Graph) compileCustomPython(aptStage llb.State) (llb.State, error) {
 	pypiMirrorStage := g.compilePyPIIndex(aptStage)
 

diff --git a/pkg/lang/ir/editor.go b/pkg/lang/ir/editor.go
@@ -93,6 +93,7 @@ func (g Graph) generateJupyterCommand(workingDir string) []string {
 	return cmd
 }
 
+// nolint:unparam
 func (g Graph) generateRStudioCommand(workingDir string) []string {
 	if g.RStudioServerConfig == nil {
 		return nil

diff --git a/pkg/lang/ir/fs.go b/pkg/lang/ir/fs.go
@@ -11,6 +11,7 @@
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
+
 package ir
 
 import (

diff --git a/pkg/lang/ir/system.go b/pkg/lang/ir/system.go
@@ -124,6 +124,7 @@ func (g Graph) compileSystemPackages(root llb.State) llb.State {
 	return run.Root()
 }
 
+// nolint:unparam
 func (g *Graph) compileExtraSource(root llb.State) (llb.State, error) {
 	if len(g.HTTP) == 0 {
 		return root, nil

diff --git a/pkg/metrics/helper.go b/pkg/metrics/helper.go
@@ -11,9 +11,12 @@
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
+
 package metrics
 
-import "math"
+import (
+	"math"
+)
 
 func round(num float64) int {
 	return int(num + math.Copysign(0.5, num))

diff --git a/pkg/progress/progressui/display.go b/pkg/progress/progressui/display.go
@@ -178,6 +178,7 @@ type vertex struct {
 	hidden bool
 }
 
+// nolint:unparam
 func (v *vertex) update(c int) {
 	if v.count == 0 {
 		now := time.Now()

diff --git a/pkg/remote/sshd/sshd.go b/pkg/remote/sshd/sshd.go
@@ -82,6 +82,7 @@ func (srv *Server) ListenAndServe() error {
 	return server.ListenAndServe()
 }
 
+//nolint:unparam
 func (srv *Server) getServer() (*ssh.Server, error) {
 	forwardHandler := &ssh.ForwardedTCPHandler{}
 

diff --git a/pkg/ssh/config/ssh_config.go b/pkg/ssh/config/ssh_config.go
@@ -92,6 +92,7 @@ func (h *host) String() string {
 
 }
 
+// nolint:unparam
 func newParam(keyword string, args, comments []string) *param {
 	return &param{
 		comments: comments,