Skip to content

Commit

Permalink
bug: fix notebook entry when setting conda channel (#719)
Browse files Browse the repository at this point in the history
fix notebook

Signed-off-by: Jinjing.Zhou <allenzhou@tensorchord.ai>
  • Loading branch information
VoVAllen committed Aug 3, 2022
1 parent 116271c commit da8feb7
Showing 1 changed file with 3 additions and 11 deletions.
14 changes: 3 additions & 11 deletions pkg/lang/ir/editor.go
Original file line number Diff line number Diff line change
Expand Up @@ -72,18 +72,10 @@ func (g Graph) generateJupyterCommand(workingDir string) []string {
return nil
}

var cmd []string
// Use python in conda env.
if g.CondaEnabled() {
cmd = append(cmd, "/opt/conda/bin/python3")
} else {
cmd = append(cmd, "python3")
}

cmd = append(cmd, []string{
"-m", "notebook",
cmd := []string{
"python3", "-m", "notebook",
"--ip", "0.0.0.0", "--notebook-dir", workingDir,
}...)
}

if g.JupyterConfig.Password != "" {
cmd = append(cmd, "--NotebookApp.password", g.JupyterConfig.Password,
Expand Down

0 comments on commit da8feb7

Please sign in to comment.