Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(CLI): Support create command #1001

Merged
merged 3 commits into from
Oct 12, 2022
Merged

feat(CLI): Support create command #1001

merged 3 commits into from
Oct 12, 2022

Conversation

gaocegege
Copy link
Member

@gaocegege gaocegege commented Oct 10, 2022 •
edited
Loading

Close #957

This PR is to:

  • Remove two hidden commands envd k8s and envd ssh
  • Add a new hidden command envd create
  • Refactor the envd/engine.go.StartEnvd()

Use flow:

# Create the envd-server, and then
$ envd context --name test1 --builder-address test --use --builder docker-container --runner envd-server ... --use
$ envd create --image gaocegege/test-envd
(base) root@a332139d39b89a241400013700e665a3:/#

Signed-off-by: Ce Gao cegao@tensorchord.ai

@muniu-bot muniu-bot bot requested review from aseaday and kemingy October 10, 2022 12:44
@muniu-bot muniu-bot bot added the approved label Oct 10, 2022
@gaocegege gaocegege changed the title WIP feat(CLI): Support create command feat(CLI): Support create command Oct 11, 2022
@gaocegege gaocegege marked this pull request as ready for review October 11, 2022 04:19
VoVAllen
VoVAllen previously approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@VoVAllen VoVAllen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can also open a new issue on how to support GPU pod launch.

@gaocegege
Copy link
Member Author

SGTM

kemingy
kemingy previously approved these changes Oct 11, 2022
View reviewed changes
pkg/envd/envdserver.go Outdated Show resolved Hide resolved
@gaocegege
Copy link
Member Author

I am updating.

image

@gaocegege
feat(CLI): Add create command
cf611b0 
Signed-off-by: Ce Gao <cegao@tensorchord.ai>
@gaocegege
fix: Fix import order
2396151 
Signed-off-by: Ce Gao <cegao@tensorchord.ai>
@gaocegege
fix: Move waitingInterval to types
cc86815 
Signed-off-by: Ce Gao <cegao@tensorchord.ai>
@gaocegege gaocegege dismissed stale reviews from kemingy and VoVAllen via cc86815 October 12, 2022 01:23
@gaocegege
Copy link
Member Author

Comments are addressed, PTAL

kemingy
kemingy approved these changes Oct 12, 2022
View reviewed changes
Copy link
Member

@kemingy kemingy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@muniu-bot muniu-bot bot added the lgtm label Oct 12, 2022
@muniu-bot
Copy link

muniu-bot bot commented Oct 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege, kemingy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaocegege gaocegege merged commit f26fc4c into tensorchord:main Oct 12, 2022
@gaocegege gaocegege deleted the create branch October 12, 2022 01:50
enjoyliu pushed a commit to enjoyliu/envd that referenced this pull request Oct 12, 2022
@gaocegege
feat(CLI): Support create command (tensorchord#1001)
a6658ce 
* feat(CLI): Add create command

Signed-off-by: Ce Gao <cegao@tensorchord.ai>

* fix: Fix import order

Signed-off-by: Ce Gao <cegao@tensorchord.ai>

* fix: Move waitingInterval to types

Signed-off-by: Ce Gao <cegao@tensorchord.ai>

Signed-off-by: Ce Gao <cegao@tensorchord.ai>
Signed-off-by: luisyjliu <luisyjliu@tencent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kemingy kemingy kemingy approved these changes

@VoVAllen VoVAllen VoVAllen left review comments

@aseaday aseaday Awaiting requested review from aseaday aseaday is a code owner

@zwpaper zwpaper Awaiting requested review from zwpaper zwpaper is a code owner

@terrytangyuan terrytangyuan Awaiting requested review from terrytangyuan

Assignees

@kemingy kemingy

Labels
approved lgtm
Projects
No open projects
envd sprint board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(CLI): envd create command
3 participants
@gaocegege @VoVAllen @kemingy