Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(CI): add nightly build & test tasks #1006

Merged
merged 4 commits into from
Oct 12, 2022
Merged

feat(CI): add nightly build & test tasks #1006

merged 4 commits into from
Oct 12, 2022

Conversation

Triple-Z
Copy link
Contributor

@Triple-Z Triple-Z commented Oct 11, 2022 •
edited
Loading

resolves #361

Signed-off-by: Triple-Z me@triplez.cn

@Triple-Z
feat(CI): add nightly build & test tasks
b8a8f58 
Signed-off-by: Triple-Z <me@triplez.cn>
@muniu-bot muniu-bot bot requested review from gaocegege and zwpaper October 11, 2022 11:41
@muniu-bot
Copy link

muniu-bot bot commented Oct 11, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Triple-Z
Once this PR has been reviewed and has the lgtm label, please assign vovallen for approval by writing /assign @vovallen in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Triple-Z
chore(CI): add manual trigger
2db1915 
Signed-off-by: Triple-Z <me@triplez.cn>
@Triple-Z
chore(nightly): expand the lint timeout to 5m
df93a5b 
Signed-off-by: Triple-Z <me@triplez.cn>
@Triple-Z Triple-Z marked this pull request as ready for review October 11, 2022 13:44
@muniu-bot muniu-bot bot requested a review from aseaday October 11, 2022 13:44
@Triple-Z
chore(CI): expand golangci-lint timeout to 5 mins
04eab76 
Signed-off-by: Triple-Z <me@triplez.cn>
@Triple-Z
Copy link
Contributor Author

The nightly.yml GH Action config is valid and passed.

@muniu-bot muniu-bot bot added the lgtm label Oct 11, 2022
gaocegege
gaocegege approved these changes Oct 12, 2022
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for your contribution! 🎉 👍

@gaocegege
Copy link
Member

/approve

@gaocegege gaocegege merged commit f288ff3 into tensorchord:main Oct 12, 2022
enjoyliu pushed a commit to enjoyliu/envd that referenced this pull request Oct 12, 2022
@Triple-Z
feat(CI): add nightly build & test tasks (tensorchord#1006)
f499015 
* feat(CI): add nightly build & test tasks

Signed-off-by: Triple-Z <me@triplez.cn>

* chore(CI): add manual trigger

Signed-off-by: Triple-Z <me@triplez.cn>

* chore(nightly): expand the lint timeout to 5m

Signed-off-by: Triple-Z <me@triplez.cn>

* chore(CI): expand golangci-lint timeout to 5 mins

Signed-off-by: Triple-Z <me@triplez.cn>

Signed-off-by: Triple-Z <me@triplez.cn>
Signed-off-by: luisyjliu <luisyjliu@tencent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaocegege gaocegege gaocegege approved these changes

@zwpaper zwpaper Awaiting requested review from zwpaper

@kemingy kemingy Awaiting requested review from kemingy kemingy is a code owner

@VoVAllen VoVAllen Awaiting requested review from VoVAllen VoVAllen is a code owner

@aseaday aseaday Awaiting requested review from aseaday

Assignees

@aseaday aseaday

@gaocegege gaocegege

Labels
lgtm
Projects
No open projects
envd sprint board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(CI): Nightly build
3 participants
@Triple-Z @gaocegege @aseaday