Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(context): Get ssh hostname from context, instead of hard-coded string #1020

Merged
merged 3 commits into from
Oct 13, 2022
Merged

feat(context): Get ssh hostname from context, instead of hard-coded string #1020

merged 3 commits into from
Oct 13, 2022

Conversation

gaocegege
Copy link
Member

Fix #1003

@gaocegege
fix: Use envd-server in the context
358a661 
Signed-off-by: Ce Gao <cegao@tensorchord.ai>
@gaocegege
feat: Add ssh address discovery
3f3abee 
Signed-off-by: Ce Gao <cegao@tensorchord.ai>
@gaocegege
fix: Remove unused struct
b9c39b8 
Signed-off-by: Ce Gao <cegao@tensorchord.ai>
@muniu-bot muniu-bot bot requested review from kemingy and VoVAllen October 13, 2022 07:07
@muniu-bot muniu-bot bot added the approved label Oct 13, 2022
@gaocegege gaocegege marked this pull request as ready for review October 13, 2022 07:10
@aseaday
Copy link
Member

aseaday commented Oct 13, 2022

LGTM

kemingy
kemingy approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@kemingy kemingy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@muniu-bot muniu-bot bot added the lgtm label Oct 13, 2022
@muniu-bot
Copy link

muniu-bot bot commented Oct 13, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege, kemingy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@muniu-bot muniu-bot bot merged commit 0fc4d8d into tensorchord:main Oct 13, 2022
@gaocegege gaocegege mentioned this pull request Nov 23, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kemingy kemingy kemingy approved these changes

@VoVAllen VoVAllen Awaiting requested review from VoVAllen VoVAllen is a code owner

@aseaday aseaday Awaiting requested review from aseaday aseaday is a code owner

@zwpaper zwpaper Awaiting requested review from zwpaper zwpaper is a code owner

Assignees

@kemingy kemingy

Labels
approved lgtm
Projects
No open projects
envd sprint board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(CLI): discover the ssh proxy address in envd-server runner
3 participants
@gaocegege @aseaday @kemingy