fix(zsh): ignore inserting zsh-completion if system don't have zsh shell #1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaocegege
reviewed
Oct 14, 2022
gaocegege
reviewed
Oct 14, 2022
gaocegege
reviewed
Oct 14, 2022
|
It seems that the mainline version can't pass the CI too. |
- Change envd's zsh-completion script name to `.envd.zsh`
- Try to write the `.envd.zsh` by the following methods:
1. write `/usr/share/zsh/site-functions/.envd.zsh` directly.
2. write `/usr/local/share/zsh/site-functions/.envd.zsh` directly.
3. write `$HOME/.envd.zsh` directly and add loaded script into the
`$HOME/.zshrc`
Signed-off-by: Triple-Z <me@triplez.cn>
Signed-off-by: Triple-Z <me@triplez.cn>
Signed-off-by: Triple-Z <me@triplez.cn>
Signed-off-by: Triple-Z <me@triplez.cn>
Triple-Z
force-pushed
the
fix-cli-zsh-completion-warning-gh-552
branch
from
a07444b
to
2308ed4
Compare
|
New changes are detected. LGTM label has been removed. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Triple-Z The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I have rebased the |
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #552
.envd.zsh.envd.zshby the following methods:/usr/share/zsh/site-functions/.envd.zshdirectly./usr/local/share/zsh/site-functions/.envd.zshdirectly.$HOME/.envd.zshdirectly and add loaded script into the$HOME/.zshrcSigned-off-by: Triple-Z me@triplez.cn