Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix zsh tab issue #1129

Merged
merged 1 commit into from
Nov 1, 2022
Merged

fix: Fix zsh tab issue #1129

merged 1 commit into from
Nov 1, 2022

Conversation

gaocegege
Copy link
Member

@gaocegege gaocegege commented Nov 1, 2022

Close #183

Test case:

def build():
    shell("zsh")

Before the PR:

~/golang via 🅒 envd 
⬢ [envd]❯ l<tab>

~/golang via 🅒 envd 
⬢ [envd]❯ l   l
l              ldconfig.real  LISTMAX        logger         lsblk          lzcmp        
la             ldd            ll             login          LS_COLORS      lzdiff       
langinfo       LESS           ln             logname        LSCOLORS       lzegrep      
last           let            local          LOGNAME        lscpu          lzfgrep   

After the PR:

~/golang via 🅒 envd 
⬢ [envd]❯ l<tab>
~/golang via 🅒 envd 
⬢ [envd]❯ l
l              ldconfig.real  LISTMAX        logger         lsblk          lzcmp        
la             ldd            ll             login          LS_COLORS      lzdiff       
langinfo       LESS           ln             logname        LSCOLORS       lzegrep      
last           let            local          LOGNAME        lscpu          lzfgrep   

Signed-off-by: Ce Gao cegao@tensorchord.ai

Signed-off-by: Ce Gao <cegao@tensorchord.ai>
@gaocegege
Copy link
Member Author

/assign @kemingy @VoVAllen

Copy link
Member

@kemingy kemingy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@muniu-bot muniu-bot bot added the lgtm label Nov 1, 2022
Copy link
Member

@VoVAllen VoVAllen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@muniu-bot
Copy link

muniu-bot bot commented Nov 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege, kemingy, VoVAllen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [VoVAllen,gaocegege,kemingy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaocegege gaocegege merged commit 8776a25 into tensorchord:main Nov 1, 2022
@gaocegege gaocegege deleted the golang branch November 1, 2022 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(ssh): Remnant characters on prompt when tab completing with ZSH
3 participants