Bug/add support for wsl2 #1134
Merged
Bug/add support for wsl2 #1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nullday <aseaday@hotmail.com>
Signed-off-by: nullday <aseaday@hotmail.com>
gaocegege
reviewed
Nov 1, 2022
VoVAllen
reviewed
Nov 2, 2022
| return true, nil | ||
| } else if strings.HasSuffix(info.KernelVersion, "WSL2") { | ||
| logrus.Warn("We couldn't detect if your runtime support GPU on WSL2, we will continue to run your environment.") | ||
| return true, nil |
There was a problem hiding this comment.
What if user doesn't have GPU with WSL?
There was a problem hiding this comment.
I raised a issue for docker win team how to detect cuda device.
But for now, users can start environment but without cuda support
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aseaday, VoVAllen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1133