Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ssh): Remove hard coded keys #120

Merged
merged 1 commit into from
May 9, 2022
Merged

chore(ssh): Remove hard coded keys #120

merged 1 commit into from
May 9, 2022

Conversation

gaocegege
Copy link
Member

@gaocegege gaocegege commented May 9, 2022 •
edited
Loading

Fix #74

Signed-off-by: Ce Gao cegao@tensorchord.ai

@gaocegege
chore(ssh): Remove hard coded keys
4f96506 
Signed-off-by: Ce Gao <cegao@tensorchord.ai>
@gaocegege gaocegege requested a review from VoVAllen May 9, 2022 03:02
VoVAllen
VoVAllen approved these changes May 9, 2022
View reviewed changes
Copy link
Member

@VoVAllen VoVAllen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean that the docker ssh no longer need any credential? Is there any security problem? Shall we open an issue to track this?

@VoVAllen
Copy link
Member

VoVAllen commented May 9, 2022

Saw #121. LGTM

@gaocegege gaocegege merged commit b95aee9 into main May 9, 2022
@gaocegege gaocegege deleted the sshr branch May 9, 2022 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoVAllen VoVAllen VoVAllen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
envd sprint board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tech-debt(CLI): Remove hard-coded ssh key in MIDI
2 participants
@gaocegege @VoVAllen