Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lang): Support git credentials #145

Merged
merged 3 commits into from
May 16, 2022
Merged

feat(lang): Support git credentials #145

merged 3 commits into from
May 16, 2022

Conversation

gaocegege
Copy link
Member

Fix #112

Signed-off-by: Ce Gao cegao@tensorchord.ai

@gaocegege
WIP
81ef979 
Signed-off-by: Ce Gao <cegao@tensorchord.ai>
@gaocegege
feat(CLI): Support ssh agent forwarding in up
94af96e 
Signed-off-by: Ce Gao <cegao@tensorchord.ai>
@gaocegege gaocegege changed the title WIP feat(lang): Support git credentials feat(lang): Support git credentials May 13, 2022
@gaocegege
fix: Update
4832f59 
Signed-off-by: Ce Gao <cegao@tensorchord.ai>
@gaocegege gaocegege requested a review from VoVAllen May 16, 2022 07:10
@gaocegege
Copy link
Member Author

@VoVAllen PTAL

VoVAllen
VoVAllen approved these changes May 16, 2022
View reviewed changes
Copy link
Member

@VoVAllen VoVAllen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need any client config to enable SSH Forward Agent? Or server config is enough?

@gaocegege
Copy link
Member Author

Does this need any client config to enable SSH Forward Agent? Or server config is enough?

#112 (comment)

In short words, client config. We configure the ssh client in golang code.

@gaocegege gaocegege merged commit 0804dc7 into main May 16, 2022
@gaocegege gaocegege deleted the upssh branch May 16, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoVAllen VoVAllen VoVAllen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
envd sprint board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(lang): Setup git credentials in containers
2 participants
@gaocegege @VoVAllen