Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Optimize err when jupyter port is already allocated #224

Merged
merged 3 commits into from
Jun 1, 2022
Merged

Conversation

gaocegege
Copy link
Member

Fix #200

Signed-off-by: Ce Gao cegao@tensorchord.ai

@gaocegege
Copy link
Member Author

Github action limit is hit, and we cannot file any new build. We should wait until tomorrow

pkg/docker/docker.go Outdated Show resolved Hide resolved
Signed-off-by: Ce Gao <cegao@tensorchord.ai>
Signed-off-by: Ce Gao <cegao@tensorchord.ai>
Signed-off-by: Ce Gao <cegao@tensorchord.ai>
@gaocegege gaocegege requested a review from VoVAllen June 1, 2022 08:10
Copy link
Member

@VoVAllen VoVAllen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This will just raise the error and won't try other ports, right?

@gaocegege
Copy link
Member Author

Yes, just as you summarized.

@gaocegege gaocegege merged commit a2ffdda into main Jun 1, 2022
@gaocegege gaocegege deleted the port branch June 1, 2022 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

bug(jupyter): Port conficts
3 participants