Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflow: enable macOS in CI #280

Merged
merged 1 commit into from
Jun 12, 2022
Merged

workflow: enable macOS in CI #280

merged 1 commit into from
Jun 12, 2022

Conversation

rudeigerc
Copy link
Member

Signed-off-by: Yuchen Cheng rudeigerc@gmail.com

Closes #271

@gaocegege
Copy link
Member

Thanks for the contribution. Maybe we should enable macOS build only for new tags.

GitHub action macOS builds are really expensive, we do not have the quota now to run it every build.

@rudeigerc
Copy link
Member Author

Got it. Updated.
Actually using expressions like this is a little bit tricky but I could not come up with a better way. 😂

@gaocegege
Copy link
Member

LGTM!

cc @terrytangyuan @VoVAllen

Signed-off-by: Yuchen Cheng <rudeigerc@gmail.com>
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaocegege gaocegege merged commit 02f83aa into main Jun 12, 2022
@gaocegege gaocegege deleted the workflow-ci-matrix branch June 12, 2022 13:02
gaocegege added a commit that referenced this pull request Jun 12, 2022
gaocegege added a commit that referenced this pull request Jun 12, 2022
rudeigerc added a commit that referenced this pull request Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

feat(CI): Enable macOS continuous build
3 participants