Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(CLI): Add go API to support LSP #302

Merged
merged 2 commits into from
Jun 20, 2022
Merged

feat(CLI): Add go API to support LSP #302

merged 2 commits into from
Jun 20, 2022

Conversation

gaocegege
Copy link
Member

@gaocegege gaocegege commented Jun 13, 2022 •
edited
Loading

This PR is to add golang API, which will be used in the LSP.

@gaocegege gaocegege mentioned this pull request Jun 16, 2022
Closed
@gaocegege
feat: Add go api package
4dace24 
Signed-off-by: Ce Gao <cegao@tensorchord.ai>
@gaocegege gaocegege changed the title feat(CLI): Add LSP WIP feat(CLI): Add go API to support LSP Jun 20, 2022
gaocegege
gaocegege commented Jun 20, 2022
View reviewed changes
Copy link
Member Author

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved the envd/api/config.py to envd/api/config/init.py, not sure if it breaks API doc gen, please have a look @VoVAllen

@gaocegege gaocegege requested a review from VoVAllen June 20, 2022 10:56
@gaocegege
fix: Update
03dca2d 
Signed-off-by: Ce Gao <cegao@tensorchord.ai>
VoVAllen
VoVAllen approved these changes Jun 20, 2022
View reviewed changes
Copy link
Member

@VoVAllen VoVAllen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaocegege gaocegege merged commit 6bd547e into tensorchord:main Jun 20, 2022
@gaocegege gaocegege deleted the lsp branch June 20, 2022 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoVAllen VoVAllen VoVAllen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
envd sprint board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaocegege @VoVAllen