Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add classifiers in setup.py #380

Merged

Conversation

Zheaoli
Copy link
Member

@Zheaoli Zheaoli commented Jun 16, 2022

Signed-off-by: Manjusaka me@manjusaka.me

@Zheaoli Zheaoli force-pushed the manjusaka/add-classifiers-in-setup branch from ac2b5ef to 42111b4 Compare June 16, 2022 10:06
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! 🎉 👍

/assign @kemingy @VoVAllen

@gaocegege gaocegege requested a review from kemingy June 16, 2022 10:07
setup.py Outdated Show resolved Hide resolved
@Zheaoli Zheaoli force-pushed the manjusaka/add-classifiers-in-setup branch from 42111b4 to 6aba4c8 Compare June 16, 2022 10:13
Copy link
Member

@kemingy kemingy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest part looks good to me.

setup.py Outdated Show resolved Hide resolved
Signed-off-by: Manjusaka <me@manjusaka.me>
@Zheaoli Zheaoli force-pushed the manjusaka/add-classifiers-in-setup branch from 6aba4c8 to 6f066c7 Compare June 16, 2022 10:23
Copy link
Member

@kemingy kemingy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaocegege gaocegege merged commit fc2afe9 into tensorchord:main Jun 16, 2022
@gaocegege
Copy link
Member

Thanks for your contribution! 🎉 👍

@Zheaoli Zheaoli deleted the manjusaka/add-classifiers-in-setup branch June 16, 2022 10:31
@gaocegege
Copy link
Member

@all-contributors Please add @Zheaoli for code contribution

@allcontributors
Copy link
Contributor

@gaocegege

I've put up a pull request to add @Zheaoli! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants