Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(destroy): add current path . as the default path #422

Merged
merged 2 commits into from
Jun 18, 2022

Conversation

Triple-Z
Copy link
Contributor

Signed-off-by: Triple-Z me@triplez.cn

closed #420

Signed-off-by: Triple-Z <me@triplez.cn>
@Triple-Z
Copy link
Contributor Author

Triple-Z commented Jun 17, 2022

This PR will have the following outputs.

$ ~/Code/envd/bin/envd destroy --help
NAME:
   envd destroy - destroys the envd environment

USAGE:
   envd destroy [command options] [arguments...]

OPTIONS:
   --name value, -n value  Name of the environment
   --path value, -p value  Path to the directory containing the build.envd (default: current directory)

BTW, maybe down is a better word than destroy:

  1. docker-compose uses it.
  2. down is the antonym for up.
  3. destroy is easy to typo :(

cc @gaocegege

@Triple-Z Triple-Z requested a review from gaocegege June 17, 2022 16:09
pkg/app/destroy.go Outdated Show resolved Hide resolved
Signed-off-by: Triple-Z <me@triplez.cn>
@gaocegege
Copy link
Member

Thanks for your contribution! 🎉 👍

@gaocegege
Copy link
Member

@all-contributors Please add @Triple-Z for his code contributions!

@allcontributors
Copy link
Contributor

@gaocegege

I've put up a pull request to add @Triple-Z! 🎉

@gaocegege gaocegege merged commit 2e287c9 into tensorchord:main Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

bug: envd destroy without any flags gets error
3 participants