Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lang): Support R language #491

Merged
merged 1 commit into from
Jun 22, 2022
Merged

feat(lang): Support R language #491

merged 1 commit into from
Jun 22, 2022

Conversation

gaocegege
Copy link
Member

This PR is to fix the broken R support.

You can use all envd primitives such as shell, in R.

Signed-off-by: Ce Gao cegao@tensorchord.ai

Signed-off-by: Ce Gao <cegao@tensorchord.ai>
Copy link
Member

@VoVAllen VoVAllen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Does remapping uid and gid have any potential issue?

@gaocegege
Copy link
Member Author

I do not think so. The remap only occurs when user's UID is 1000. And 1000 already exists in the R language image, thus we can use it safely. The only disadvantage is that we created a unused UID.

@gaocegege gaocegege merged commit 7127365 into tensorchord:main Jun 22, 2022
@gaocegege gaocegege deleted the r branch June 22, 2022 08:57
@terrytangyuan
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants