Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support specify build target #497

Merged
merged 8 commits into from
Jul 5, 2022
Merged

Conversation

VoVAllen
Copy link
Member

@VoVAllen VoVAllen commented Jun 23, 2022

Fix #403
Support syntax like envd up -f :build_gpu to specify the function to be called

Signed-off-by: Jinjing.Zhou <allenzhou@tensorchord.ai>
Signed-off-by: Jinjing.Zhou <allenzhou@tensorchord.ai>
Signed-off-by: Jinjing.Zhou <allenzhou@tensorchord.ai>
@VoVAllen VoVAllen changed the title feat: Support specify build target feat: Support specify build target WIP Jun 23, 2022
Signed-off-by: Jinjing.Zhou <allenzhou@tensorchord.ai>
Signed-off-by: Jinjing.Zhou <allenzhou@tensorchord.ai>
@VoVAllen VoVAllen changed the title feat: Support specify build target WIP feat: Support specify build target Jul 5, 2022
Signed-off-by: Jinjing.Zhou <allenzhou@tensorchord.ai>
Signed-off-by: Jinjing.Zhou <allenzhou@tensorchord.ai>
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some nits

examples/mnist/build.envd Outdated Show resolved Hide resolved
examples/mnist/README.md Show resolved Hide resolved
Signed-off-by: Jinjing.Zhou <allenzhou@tensorchord.ai>
@gaocegege
Copy link
Member

LGTM

@gaocegege gaocegege merged commit 6e9e44d into tensorchord:main Jul 5, 2022
@VoVAllen VoVAllen deleted the addfrom branch July 5, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

discussion(lang): How to support multi-target
2 participants