Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Julia multiple pkg installation bug #521

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

aaronzs
Copy link
Contributor

@aaronzs aaronzs commented Jun 28, 2022

Fix the following bug when install multiple Julia pkgs

Pkg.add("IJulia", "Example")
 => ERROR install julia packages                                                                                                                                                                            6.0s
------
 > install julia packages:
#0 0.737 ERROR: MethodError: no method matching add(::String, ::String)
#0 5.958 Closest candidates are:
#0 5.958   add(::Union{AbstractString, Pkg.Types.PackageSpec}; kwargs...) at /usr/local/julia/share/julia/stdlib/v1.8/Pkg/src/API.jl:143
#0 5.958 Stacktrace:
#0 5.958  [1] top-level scope
#0 5.958    @ none:1
------
ERRO[2022-06-28T13:50:32+08:00] failed to load docker image: Post "http://%2Fvar%2Frun%2Fdocker.sock/v1.41/images/load?quiet=1": context canceled  tag="envd-julia:dev"
error: process "/usr/local/julia/bin/julia -e using Pkg; Pkg.add(\"IJulia\", \"Example\")" did not complete successfully: exit code: 1

Signed-off-by: Aaron Sun <aaronzs@users.noreply.github.com>
@aaronzs aaronzs force-pushed the bugfix_julia_pkg_list_install branch from 3627b10 to d33d73b Compare June 28, 2022 06:44
@gaocegege
Copy link
Member

Thanks! I do not think the test failure is caused by the change. I will rerun it

@gaocegege gaocegege merged commit 04e8444 into tensorchord:main Jun 28, 2022
@gaocegege
Copy link
Member

Thanks for your contribution! 🎉 👍

@aaronzs aaronzs deleted the bugfix_julia_pkg_list_install branch June 28, 2022 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants