Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use DefaultText in up.go #587

Merged
merged 1 commit into from
Jul 11, 2022
Merged

Use DefaultText in up.go #587

merged 1 commit into from
Jul 11, 2022

Conversation

gyli
Copy link
Contributor

@gyli gyli commented Jul 11, 2022

Fixes #450
Signed-off-by: Guangyang Li bot@guangyangli.com

@gyli
Use DefaultText in up.go
8cf311c 
Signed-off-by: Guangyang Li <bot@guangyangli.com>
@gaocegege
Copy link
Member

Thanks for your contribution! 🎉 👍

@gaocegege gaocegege merged commit 00249bb into tensorchord:main Jul 11, 2022
@gaocegege
Copy link
Member

@all-contributors Please add @gyli for the code contribution.

@allcontributors allcontributors bot mentioned this pull request Jul 11, 2022
Merged
@allcontributors
Copy link
Contributor

@gaocegege

I've put up a pull request to add @gyli! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaocegege gaocegege gaocegege approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
envd sprint board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enhancement(CLI): Use DefaultText to avoid hard coded default strings
2 participants
@gyli @gaocegege