Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(base-image): Move conda to llb and cache it #724

Merged
merged 4 commits into from
Aug 5, 2022

Conversation

gaocegege
Copy link
Member

@gaocegege gaocegege commented Aug 4, 2022

Ref #667

This PR is to:

  • Move conda installation into ir package (which means that it is re-implemented with llb.State)
  • Add default remote cache for python 3.9 in base-images/remote-cache.
  • Add envd version tag into base images.
  • Support building remote cache and base images in CI

Signed-off-by: Ce Gao <cegao@tensorchord.ai>
@gaocegege gaocegege changed the title WIP: feat(base-image): Move conda to llb and cache it feat(base-image): Move conda to llb and cache it Aug 4, 2022
Signed-off-by: Ce Gao <cegao@tensorchord.ai>
Copy link
Member

@aseaday aseaday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -64,16 +64,9 @@ jobs:
matrix:
os: [ubuntu-latest]
runs-on: ${{ matrix.os }}
env:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The modifiction of CI seems not directly related to the feature?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is to make the action actions-ecosystem/action-get-latest-tag@v1 happy.

Copy link
Member

@VoVAllen VoVAllen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

base-images/build.sh Outdated Show resolved Hide resolved
base-images/remote-cache/build-and-push-remote-cache.sh Outdated Show resolved Hide resolved
gaocegege and others added 2 commits August 5, 2022 14:15
Co-authored-by: Keming <kemingy94@gmail.com>
Co-authored-by: Keming <kemingy94@gmail.com>
@gaocegege gaocegege merged commit 8c83cad into tensorchord:main Aug 5, 2022
@gaocegege gaocegege deleted the cache branch August 5, 2022 08:13
@kemingy kemingy mentioned this pull request Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants