Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ParseFromStr, add unittest #755

Merged
merged 1 commit into from
Aug 10, 2022
Merged

fix: ParseFromStr, add unittest #755

merged 1 commit into from
Aug 10, 2022

Conversation

kemingy
Copy link
Member

@kemingy kemingy commented Aug 10, 2022

@kemingy kemingy requested a review from VoVAllen August 10, 2022 11:33
@kemingy
fix: ParseFromStr, add unittest
6d00d59 
Signed-off-by: Keming <kemingyang@tensorchord.ai>
VoVAllen
VoVAllen approved these changes Aug 10, 2022
View reviewed changes
Copy link
Member

@VoVAllen VoVAllen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@VoVAllen VoVAllen merged commit 8675316 into tensorchord:main Aug 10, 2022
@kemingy kemingy deleted the fix_parse_from_str branch August 10, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoVAllen VoVAllen VoVAllen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
envd sprint board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kemingy @VoVAllen