Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(lint): make linter happy #97

Merged
merged 1 commit into from
May 3, 2022
Merged

chore(lint): make linter happy #97

merged 1 commit into from
May 3, 2022

Conversation

Thrimbda
Copy link
Member

@Thrimbda Thrimbda commented May 2, 2022 •
edited
Loading

fix #96

@Thrimbda Thrimbda requested a review from gaocegege May 2, 2022 13:00
Thrimbda
Thrimbda commented May 2, 2022
View reviewed changes
Makefile Show resolved Hide resolved
Makefile Show resolved Hide resolved
Makefile Show resolved Hide resolved
gaocegege
gaocegege approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! 🎉 👍

LGTM. Should we run the linter in GitHub actions?

Makefile Show resolved Hide resolved
Makefile Show resolved Hide resolved
@gaocegege gaocegege merged commit d847350 into main May 3, 2022
@gaocegege gaocegege deleted the chore-make-linter-happy branch May 3, 2022 01:06
@gaocegege gaocegege mentioned this pull request May 3, 2022
Closed
@Thrimbda
Copy link
Member Author

Thrimbda commented May 3, 2022

Should we run the linter in GitHub actions?

I think we should, yet there are still two lint error, both related to the deprecated usage of pem file, what do you think of that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaocegege gaocegege gaocegege approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
envd sprint board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore(lint): there are a bunch of unchecked error return value
2 participants
@Thrimbda @gaocegege