Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ir): make sure default value won't be replaced with empty value #970

Merged
merged 1 commit into from
Oct 7, 2022

Conversation

kemingy
Copy link
Member

@kemingy kemingy commented Oct 7, 2022

Signed-off-by: Keming kemingyang@tensorchord.ai

Signed-off-by: Keming <kemingyang@tensorchord.ai>
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@muniu-bot muniu-bot bot added the lgtm label Oct 7, 2022
@muniu-bot
Copy link

muniu-bot bot commented Oct 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege, kemingy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@muniu-bot muniu-bot bot merged commit 17fedb8 into tensorchord:main Oct 7, 2022
@kemingy kemingy deleted the ir_default_value branch October 7, 2022 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants