feat(build): detect if the current environment is running before building (#892) #989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome @Belyenochi! It looks like this is your first PR to tensorchord/envd 🎉 |
…ding (tensorchord#892) Signed-off-by: Belyenochi <491537461q@gmail.com>
Belyenochi
force-pushed
the
feat/support-detect-env-before-build
branch
from
4fe313d
to
b25d7e5
Compare
Signed-off-by: Belyenochi <491537461q@gmail.com>
kemingy
reviewed
Oct 9, 2022
Signed-off-by: Belyenochi <491537461q@gmail.com>
Belyenochi
requested review from
kemingy
and removed request for
zwpaper and
aseaday
|
/approve Thanks for your contribution! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Belyenochi, gaocegege, kemingy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@all-contributors Please add @Belyenochi for the code contribution. |
|
I've put up a pull request to add @Belyenochi! 🎉 |
enjoyliu
pushed a commit
to enjoyliu/envd
that referenced
this pull request
Oct 12, 2022
…ding (tensorchord#892) (tensorchord#989) * feat(build): detect if the current environment is running before building (tensorchord#892) Signed-off-by: Belyenochi <491537461q@gmail.com> * fix: update docker engine create (tensorchord#892) Signed-off-by: Belyenochi <491537461q@gmail.com> * fix: move running check to detect env function Signed-off-by: Belyenochi <491537461q@gmail.com> Signed-off-by: Belyenochi <491537461q@gmail.com> Signed-off-by: luisyjliu <luisyjliu@tencent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support #892