feat: Support cli argument for host key #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ce Gao <cegao@tensorchord.ai>
Signed-off-by: Ce Gao <cegao@tensorchord.ai>
VoVAllen
reviewed
Oct 9, 2022
pkg/ssh/ssh.go
Outdated
| // create agent and add in auth | ||
| forwardingAgent := agent.NewClient(agentConn) | ||
| // add callback for forwarding agent to SSH config | ||
| // XXX - might want to handle reconnects appending multiple callbacks |
Signed-off-by: Ce Gao <cegao@tensorchord.ai>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege, VoVAllen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
enjoyliu
pushed a commit
to enjoyliu/envd
that referenced
this pull request
Oct 12, 2022
* feat: Support cli argument for host key Signed-off-by: Ce Gao <cegao@tensorchord.ai> * fix: Update Signed-off-by: Ce Gao <cegao@tensorchord.ai> * fix: Remove comments Signed-off-by: Ce Gao <cegao@tensorchord.ai> Signed-off-by: Ce Gao <cegao@tensorchord.ai> Signed-off-by: luisyjliu <luisyjliu@tencent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://pkg.go.dev/github.com/gliderlabs/ssh@v0.3.5
The host key in envd-sshd is generated every time. Thus the fingerprint of the sshd always changes. This PR is to add a cli argument to support custom host key.
Ref #101
Signed-off-by: Ce Gao cegao@tensorchord.ai