Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: transactional CREATE/DROP #279

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Conversation

usamoi
Copy link
Collaborator

@usamoi usamoi commented Jan 17, 2024

No description provided.

Signed-off-by: usamoi <usamoi@outlook.com>
@VoVAllen
Copy link
Member

Can we add some tests for this?

@usamoi
Copy link
Collaborator Author

usamoi commented Jan 17, 2024

Can we add some tests for this?

I do not know how to test it.

@cutecutecat
Copy link
Member

Can we add some tests for this?

I do not know how to test it.

Maybe we can start from what does this issue solved? Before and after?

@usamoi
Copy link
Collaborator Author

usamoi commented Jan 17, 2024

Can we add some tests for this?

I do not know how to test it.

Maybe we can start from what does this issue solved? Before and after?

The remote index created by CREATE will be removed if the transaction is aborted.

@cutecutecat
Copy link
Member

In previous discussion, if a user enter ctrl+c before SQL CREATE INDEX returned. At backend, pgvecto.rs will generate a leaked index which is never used and unmaintained forever.

This PR would trigger a index cleaner every time user send ctrl+c.

To test it, we might need a python script to send abort and check whether the index file is cleared soon later, which could be done later.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As flush caller is removed, do we still need IndexView.flush() and InstanceView.flush()?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just moved to Commit.

VoVAllen
VoVAllen previously approved these changes Jan 17, 2024
Signed-off-by: usamoi <usamoi@outlook.com>
@usamoi usamoi added this pull request to the merge queue Jan 17, 2024
Merged via the queue into tensorchord:main with commit 727d69f Jan 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants