-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: transactional CREATE/DROP #279
Conversation
Signed-off-by: usamoi <usamoi@outlook.com>
Can we add some tests for this? |
I do not know how to test it. |
Maybe we can start from what does this issue solved? Before and after? |
The remote index created by CREATE will be removed if the transaction is aborted. |
In previous discussion, if a user enter This PR would trigger a index cleaner every time user send To test it, we might need a python script to send |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As flush
caller is removed, do we still need IndexView.flush()
and InstanceView.flush()
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's just moved to Commit
.
08c10a9
to
025c482
Compare
Signed-off-by: usamoi <usamoi@outlook.com>
No description provided.