fix: support null insert #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://github.com/pgvector/pgvector/blob/master/src/hnswinsert.c#L635-L649 Line 158 in 558c43a |
cutecutecat
force-pushed
the
support-null
branch
2 times, most recently
from
be7d8eb
to
f359560
Compare
Signed-off-by: cutecutecat <junyuchen@tensorchord.ai>
cutecutecat
force-pushed
the
support-null
branch
from
f359560
to
ec9eb92
Compare
usamoi
reviewed
Feb 27, 2024
usamoi
previously approved these changes
Feb 27, 2024
|
Please cherry pick this into 0.2 branch |
cutecutecat
added a commit
to cutecutecat/pgvecto.rs
that referenced
this pull request
Feb 27, 2024
* fix: support null insert Signed-off-by: cutecutecat <junyuchen@tensorchord.ai> * fix Signed-off-by: cutecutecat <junyuchen@tensorchord.ai> * fix Signed-off-by: cutecutecat <junyuchen@tensorchord.ai> --------- Signed-off-by: cutecutecat <junyuchen@tensorchord.ai>
cutecutecat
added a commit
that referenced
this pull request
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #386
Part of #376 , we still need a patch for upgrade to v0.2.0