Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove prefilter, stand-alone-test and default feature #505

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

usamoi
Copy link
Collaborator

@usamoi usamoi commented Jun 19, 2024

This pull request

  • removes prefilter: the implementation is not usable at all and blocks future work
  • removes stand-alone-test: it's just a copy of hnsw
  • removes default feature pg15 in Cargo.toml to avoid too many --no-default-features for whom does not install PostgreSQL 15.

If you're developing with PostgreSQL 16, after this pr is merged, you need to add following json snippet to .vscode/settings.json.

"rust-analyzer.cargo.features": [
    "pg16"
],

Signed-off-by: usamoi <usamoi@outlook.com>
Signed-off-by: usamoi <usamoi@outlook.com>
@usamoi
Copy link
Collaborator Author

usamoi commented Jun 19, 2024

It does not add any new code, can it be merged (without waiting for 0.3.0 release)? @VoVAllen

@VoVAllen VoVAllen added this pull request to the merge queue Jun 20, 2024
Merged via the queue into tensorchord:main with commit 4360cac Jun 20, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants