Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use x86-64-v3 as target cpu #51

Merged
merged 1 commit into from
Aug 17, 2023
Merged

fix: use x86-64-v3 as target cpu #51

merged 1 commit into from
Aug 17, 2023

Conversation

usamoi
Copy link
Collaborator

@usamoi usamoi commented Aug 17, 2023

Currently releases built by GitHub runners cannot run on machines without AVX-512 instructions. "x86-64-v3" relaxs the restriction for target instruction sets.

Signed-off-by: usamoi <usamoi@outlook.com>
@VoVAllen VoVAllen merged commit cfd893a into main Aug 17, 2023
1 check passed
@VoVAllen VoVAllen deleted the usamoi-patch-1 branch August 17, 2023 14:42
@TIAcode
Copy link

TIAcode commented Aug 28, 2024

cargo:warning=./src/f16.c:84:15: error: always_inline function '_mm512_set1_ps' requires target feature 'avx512f', but would be inlined into function 'v_f16_cosine_v4' that is compiled without support for 'avx512f'

The commit that fixed this a year ago isn't included in the sources anymore. Compiling this without AVX-512 runs into a ton of these errors. Would it still be possible to compile without it?

@usamoi
Copy link
Collaborator Author

usamoi commented Aug 29, 2024

cargo:warning=./src/f16.c:84:15: error: always_inline function '_mm512_set1_ps' requires target feature 'avx512f', but would be inlined into function 'v_f16_cosine_v4' that is compiled without support for 'avx512f'

The commit that fixed this a year ago isn't included in the sources anymore. Compiling this without AVX-512 runs into a ton of these errors. Would it still be possible to compile without it?

Can you explain what problems do you want to solve? v_f16_cosine_v4 is decorated by __attribute__((target("arch=x86-64-v4,avx512fp16"))) so there should not be this warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants