-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate ImageProjectiveTransformV2 #1779
Comments
This comment has been minimized.
This comment has been minimized.
Yeah I believe those are separate issues. For |
I believe any redundancy is bad. If we have this in TF core, then I suggest we start with a deprecation warning and remove it gradually in the next version |
Thanks @bhack for bringing this to our attention! I believe we should replace the body of our implementation and call the one in TF while keeping the same API on our side for backward compatibility. If the TF implementation is the same as ours, the tests should pass. Though we should also keep the C++/CUDA code on our side for a while because if we remove the custom op, people trying to load their models will get an error. But the biggest problem right now is that we can't access their implementation because it's not exposed in the public API (as far as I know). We could ask the TF team to expose it for TF 2.3? At least it doesn't seem that we're in a hurry. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Cleaning up the discussion for the future readers. |
I removed all the comments here and also the original comment on the @WindQAQ PR that generated this ISSUE. |
ImageProjectiveTransformV2
seems to be integrated into core TF at tensorflow/tensorflow@2699281 in Jan. We have to deprecate the use of it.https://github.com/tensorflow/addons/blob/master/tensorflow_addons/custom_ops/image/cc/kernels/image_projective_transform_op.cc
Also, it was unclear to me that
ImageProjectiveTransformV2
has been integrated into TF many months ago. Maybe we should check new stuff in TF regularly. Thanks @bhack for pointing out!cc @tensorflow/sig-addons-maintainers
The text was updated successfully, but these errors were encountered: