-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support extended mode on projective transform #1721
Support extended mode on projective transform #1721
Conversation
You are owner of some files modified in this pull request. |
@WindQAQ overall looking good but I have one query. Please check the inline comments I have made |
tensorflow_addons/custom_ops/image/cc/kernels/image_projective_transform_op.cc
Show resolved
Hide resolved
@WindQAQ Looks great to me! Definitely preferable to #1719. Only thing is that it would be nice if the different extended modes could be used separately (outside of projective transforms) for more flexibility. For example, I mentioned that I liked to extend the image before performing some image ops like |
We can have both of them actually if they are both useful :-) |
@bhack It seems that it is migrated to core TF in Jan. I have no idea about this. Thanks for pointing out! cc @tensorflow/sig-addons-maintainers |
Never mind 😄 I don't even care about it LOL. Your links are super helpful for me.
Umm, it seems to be the miscommunication between us and many places. A related issue has been posted #1779. Thanks again for pointing out it :-) |
@WindQAQ Users are looking for some of these filling parameters at tensorflow/tensorflow#39177 |
Closed #1318. Support extend mode on projective transform. Mainly follow the scipy's implementation.
From top to bottom: original, reflect, constant, mirror, nearest, wrap. Addons is on the left, scipy is on the right.
Testing script: