Better user experience when the version of TF is not right. #1281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpmorgan
reviewed
Mar 12, 2020
| import tensorflow as tf | ||
|
|
||
|
|
||
| warning_template = """ |
There was a problem hiding this comment.
Just curious why this was pulled out of the function? Not likely to be an issue but if we don't need to add a variable to global space then I don't see a reason to?
There was a problem hiding this comment.
It's just prettier as I don't have to break the indentation in the function to write the message. If you prefer that I put it in the function, I have nothing against that.
seanpmorgan
added
the
backport r0.8
jrruijli
pushed a commit
to jrruijli/addons
that referenced
this pull request
Dec 23, 2020
…ow#1281) * Better user experience when the version of TF is not right.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1277