Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix master: Keep pip version constant #1760

Merged

Conversation

seanpmorgan
Copy link
Member

@seanpmorgan seanpmorgan commented Apr 30, 2020

No need to upgrade these two packages in our build environment.. this can introduce possible errors we don't control

@seanpmorgan
Copy link
Member Author

So the macos wheels are failing for 403 on github api requesting bazel releases. I've ran into something similar for another project and I think this is related to all macos VMs running the same IP address:
actions/runner-images#602 (comment)

If there's anyway we can authenticate the API request that would solve the issue but seeing as it's done inside of bazel build this may be tricky to do.

@boring-cyborg boring-cyborg bot added the github label Apr 30, 2020
@seanpmorgan seanpmorgan changed the title Fix master: Keep pip version constant [WIP] Fix master: Keep pip version constant Apr 30, 2020
@seanpmorgan seanpmorgan changed the title [WIP] Fix master: Keep pip version constant Fix master: Keep pip version constant Apr 30, 2020
@gabrieldemarmiesse
Copy link
Member

We're merging this because it's urgent, but I believe the setup bazel step should be skipped on linux and windows, we already have bazel installed in docker and on windows it's downloaded in the bash script.

@gabrieldemarmiesse gabrieldemarmiesse merged commit d4ebfca into tensorflow:master Apr 30, 2020
@seanpmorgan seanpmorgan deleted the keep-pip-version-constant branch April 30, 2020 19:22
ashutosh1919 pushed a commit to ashutosh1919/addons that referenced this pull request Jul 12, 2020
* Remove pip upgrade

* Remove pip upgrades that are not needed

* debug

* debug

* debug

* Try with github token

* Fix bug

* temp

* Update
jrruijli pushed a commit to jrruijli/addons that referenced this pull request Dec 23, 2020
* Remove pip upgrade

* Remove pip upgrades that are not needed

* debug

* debug

* debug

* Try with github token

* Fix bug

* temp

* Update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants