Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md markdown highlight #2033

Closed
wants to merge 2 commits into from

Conversation

archsyscall
Copy link
Contributor

@archsyscall archsyscall commented Jul 23, 2020

Description

Code highlights applied to README.md

Fixes # (issue)

Type of change

How Has This Been Tested?

If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes:
*

Checklist:

  • I've properly formatted my code according to the guidelines
    • By running Black + Flake8
    • By running pre-commit hooks
  • This PR addresses an already submitted issue for TensorFlow Addons
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • This PR contains modifications to C++ custom-ops

@bhack bhack self-requested a review July 23, 2020 11:58
Copy link
Contributor

@bhack bhack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On which tool the Markdown formatting was done?

@archsyscall
Copy link
Contributor Author

마크 다운 형식화는 어떤 도구에서 수행 되었습니까?

done in prettier

@bhack
Copy link
Contributor

bhack commented Jul 23, 2020

If you want this or something like this I think It Is better that you open a separate ticket to collect consensus on introducing a Markdown linter/formatter pass as there are many solutions.
Using the tool locally don't help us to have an homogenus approach.
E.g. see #1808

@seanpmorgan
Copy link
Member

Agree with @bhack here. If we want to lint our markdown files lets discuss agree on a formatter in a seperate issue first. Closing for now.

@archsyscall archsyscall deleted the ReadmeUpdate branch July 23, 2020 15:42
@archsyscall
Copy link
Contributor Author

Thank You!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants